Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 #29

Merged
merged 38 commits into from
Apr 11, 2022
Merged

1.2.0 #29

merged 38 commits into from
Apr 11, 2022

Conversation

lakhoune
Copy link
Member

@lakhoune lakhoune commented Apr 9, 2022

Develop and master have not been merged for a long time. Consequently, the master is still using ant and Travis. This pull request introduces Gradle which has been introduced on develop for quite some time now

@lakhoune lakhoune requested a review from Aran30 April 9, 2022 15:06
@@ -54,6 +54,7 @@ public class MobSOSDataProcessingService extends Service {
private Set<String> triggerFunctions = new HashSet<String>();
private ArrayList<BotMessage> botMessages = new ArrayList<BotMessage>();
private ArrayList<String> xAPIstatements = new ArrayList<String>();
//private boolean sendStatementsToBots = true; // True if xAPI statements should also be sent to the social bot manager service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. This was introduced in 1bcbd2d

Copy link
Contributor

@Aran30 Aran30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@lakhoune lakhoune merged commit 5596a08 into master Apr 11, 2022
@lakhoune lakhoune mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants